Skip to content
This repository has been archived by the owner on Jan 18, 2021. It is now read-only.

Allow type checking #77

Merged
merged 4 commits into from
Apr 16, 2018
Merged

Allow type checking #77

merged 4 commits into from
Apr 16, 2018

Conversation

Eddman
Copy link
Contributor

@Eddman Eddman commented Mar 7, 2018

Fixes #67. As there seems to be no development in #73...

Added option project. It is the equivalent to tslint --project argument. Uses Linter.createProgram to create program for type checking.

@palantirtech
Copy link
Member

Thanks for your interest in palantir/grunt-tslint, @Eddman! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

@Eddman
Copy link
Contributor Author

Eddman commented Mar 14, 2018

Is this repo still alive?

@dasa
Copy link

dasa commented Apr 15, 2018

Maybe there's an issue with the contributor license agreement? It'd be great to have this PR merged.

@dasa
Copy link

dasa commented Apr 15, 2018

@adidahiya would you be able to help with this?

@Eddman
Copy link
Contributor Author

Eddman commented Apr 15, 2018

The license is signed...

@suchanlee suchanlee requested a review from jkillian April 16, 2018 01:12
@suchanlee
Copy link
Contributor

LGTM, thanks!

@suchanlee suchanlee merged commit 02ef68d into palantir:master Apr 16, 2018
@kierans
Copy link

kierans commented Apr 17, 2018

When do you plan to release 5.0.2? It was confusing for me to see that the project option was available in the README but the linting wasn't working correctly. Only after digging did I find this PR.

@suchanlee
Copy link
Contributor

@kierans just released 5.0.2

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants