Skip to content
This repository has been archived by the owner on Aug 15, 2024. It is now read-only.

Stop manipulating compiler.xml when importing from IDEA #90

Merged
merged 3 commits into from
Oct 12, 2018

Conversation

dansanduleac
Copy link
Contributor

Before this PR

If importing IDEA using a directory-based project, the plugin would modify your .idea/compiler.xml to set the expected annotation processor directories.

After this PR

When importing from IDEA, the compiler.xml file is left alone.

@iamdanfox
Copy link
Contributor

Let's do a publishToMavenLocal and ensure that the open *.ipr workflow still works!

Copy link
Contributor

@iamdanfox iamdanfox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this as this approach was recommended by @alicederyn earlier

@dansanduleac
Copy link
Contributor Author

Confirmed still works and behaves as expected on both .idea/ and .ipr projects.

@dansanduleac dansanduleac merged commit fe91df5 into master Oct 12, 2018
@dansanduleac dansanduleac deleted the ds/stop-messing-with-idea-xmls branch October 12, 2018 16:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants