This repository has been archived by the owner on Aug 15, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 23
Point to the classes dir of processors that are other subprojects #113
Merged
bulldozer-bot
merged 10 commits into
master
from
ds/resolve-processor-subprojects-classes-dir
Sep 2, 2019
Merged
Point to the classes dir of processors that are other subprojects #113
bulldozer-bot
merged 10 commits into
master
from
ds/resolve-processor-subprojects-classes-dir
Sep 2, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… IDEA output path
…r-subprojects-classes-dir
ping on this please 🙏 |
dansanduleac
commented
Aug 20, 2019
def outputDir = dependencyModule.outputDir | ||
?: project.rootProject.file("${projectOutputDir}/production/${dependencyModule.name}") | ||
log.lifecycle("Configuring annotation dependency ${project.path} -> ${dependencyProject.path} with output dir: $outputDir") | ||
return outputDir |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
intent here is to make the annotation-processor classpath entry point to intellij's output directory for that dependencyProject
, so that changes to dependencyProject
can be seamlessly picked up when compiling "this" project (variable project
)
…r-subprojects-classes-dir
j-baker
approved these changes
Sep 2, 2019
bulldozer-bot
bot
deleted the
ds/resolve-processor-subprojects-classes-dir
branch
September 2, 2019 10:48
Released 3.1.0 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
If a project defines a project with annotation processors (A) that another project (B) then consumes, in the same gradle build, it's necessary to keep doing
./gradlew idea
every time you change the code in A, in order to see the new classes.This is onerous.
After this PR
==COMMIT_MSG==
Configure inter-project annotation processor dependencies correctly in IDEA.
==COMMIT_MSG==
This PR is blocked on #115.