This repository has been archived by the owner on Aug 15, 2024. It is now read-only.
Don't configure jacoco to exclude generated files in gradle 5+ #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sixinli
approved these changes
Mar 6, 2019
|
@dansanduleac given that this hasn't got any tests, can you confirm this has been verified locally? |
dansanduleac
force-pushed
the
ds/dont-jacoco-gradle-5
branch
from
3c81612 to
a31b603
Compare
|
@iamdanfox added tests |
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
Jacoco logic to exclude generated code from code coverage fails on Gradle 5.0+
After this PR
We don't attempt to configure jacoco if Gradle is 5.0 or higher