Fix body size telemetry when ReadFrom is used #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes a small API break due to AccessHandler hooks using int64 instead of int for size.
bluekeyes
reviewed
Mar 26, 2020
There was a problem hiding this comment.
I agree that the implementation here is close enough to the version from zenazn/goji that it's probably worth including the original license in a header comment in that file, probably with a not that it has been modified, in addition to the header for this project. At minimum, we should include a link to original source.
bluekeyes
approved these changes
Mar 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes a small API break due to AccessHandler
hooks using int64 instead of int for size.