chore: Refactor Alert from a class to functional component #7184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
chore: Refactor Alert from a class to functional componentBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
ggdouglas
force-pushed
the
gd/refactor-alert
branch
from
2d2d236 to
bdef9c0
Compare
Use mount in test to trigger warningsBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
jscheiny
reviewed
Jan 17, 2025
| } = props; | ||
|
|
||
| React.useEffect(() => { | ||
| if (onClose == null && (cancelButtonText == null) !== (onCancel == null)) { |
There was a problem hiding this comment.
See my comment on spinner changes: https://github.com/palantir/blueprint/pull/7181/files#r1920669985
There was a problem hiding this comment.
Changed in 01c9f2b
ggdouglas
force-pushed
the
gd/refactor-alert
branch
from
bdef9c0 to
01c9f2b
Compare
Use useValidateProps hook to wrap prop validation warningsBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
jscheiny
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #6289
Changes:
Refactors
Alertfrom a class-based to functional component. All functionality should remain preserved.Example: Before / After