-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Refactor Dialog sub-components to be functional components #7180
Conversation
Generate changelog in
|
a843e72
to
2b2468e
Compare
Refactor Dialog sub-components to be functional componentsBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
2b2468e
to
78bb824
Compare
Refactor Dialog sub-components to be functional componentsBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor comment, approved to unblock
Invalidated by push of 04327c2
Remove comments in DialogFooterBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
Part of #6289
Changes:
Refactors
Dialog
sub-components (DialogBody
,DialogFooter
, &DialogStep
) from class-based to functional components. All functionality should remain preserved.Also allows
htmlProps
to be spread onto each component to allow passing ofdata-*
props to components. (see #3763)Example: Before / After