Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Refactor Dialog sub-components to be functional components #7180

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

ggdouglas
Copy link
Contributor

@ggdouglas ggdouglas commented Jan 17, 2025

Part of #6289

Changes:

Refactors Dialog sub-components (DialogBody, DialogFooter, & DialogStep) from class-based to functional components. All functionality should remain preserved.

Also allows htmlProps to be spread onto each component to allow passing of data-* props to components. (see #3763)

Example: Before / After

@changelog-app
Copy link

changelog-app bot commented Jan 17, 2025

Generate changelog in packages/core/changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Refactor Dialog sub-components to be functional components

Check the box to generate changelog(s)

  • Generate changelog entry

@ggdouglas ggdouglas force-pushed the gdouglas/refactor-dialog-sub-components branch from a843e72 to 2b2468e Compare January 17, 2025 15:30
@svc-palantir-github
Copy link

Refactor Dialog sub-components to be functional components

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@ggdouglas ggdouglas changed the title Refactor Dialog sub-components to be functional components chore: Refactor Dialog sub-components to be functional components Jan 17, 2025
@ggdouglas ggdouglas force-pushed the gdouglas/refactor-dialog-sub-components branch from 2b2468e to 78bb824 Compare January 17, 2025 16:22
@svc-palantir-github
Copy link

Refactor Dialog sub-components to be functional components

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

jscheiny
jscheiny previously approved these changes Jan 17, 2025
Copy link
Contributor

@jscheiny jscheiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment, approved to unblock

packages/core/src/components/dialog/dialogFooter.tsx Outdated Show resolved Hide resolved
@policy-bot policy-bot bot dismissed jscheiny’s stale review January 17, 2025 19:51

Invalidated by push of 04327c2

@svc-palantir-github
Copy link

Remove comments in DialogFooter

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@ggdouglas ggdouglas merged commit 37e182e into develop Jan 17, 2025
11 of 14 checks passed
@ggdouglas ggdouglas deleted the gdouglas/refactor-dialog-sub-components branch January 17, 2025 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants