Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v5] [icons] fix static icon component size, remove built-in webpack loaders #6222

Merged
merged 9 commits into from
Jun 14, 2023
+251 −157
Merged

[v5] [icons] fix static icon component size, remove built-in webpack loaders #6222

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
8daa8d0
[v5] [colors] fix lint
adidahiya Jun 14, 2023
bd9b914
[v5] [icons] Defer loading of webpack loaders
adidahiya Jun 14, 2023
91ae5e0
fix paths in webpack-loaders
adidahiya Jun 14, 2023
39a71df
fix #6220, add example to verify fix
adidahiya Jun 14, 2023
0b26263
Remove extra loaders
adidahiya Jun 14, 2023
c98a395
Fix typo
adidahiya Jun 14, 2023
a5cf448
Remove built-in webpack loaders
adidahiya Jun 14, 2023
e1876c0
Fix tests
adidahiya Jun 14, 2023
9dd534a
Delete dead code
adidahiya Jun 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix paths in webpack-loaders
@adidahiya
adidahiya committed Jun 14, 2023

Verified

This commit was signed with the committer’s verified signature.
citizenmatt Matt Ellis
GPG key ID: FA6025D54131324B
Verified
Learn about vigilant mode
commit 91ae5e0d631a1b4b9f70bbe2a3880ff15033c112
4 changes: 2 additions & 2 deletions packages/icons/src/webpack-loaders/webpackEagerPathsLoader.ts
View file
Original file line number Diff line number Diff line change
@@ -29,13 +29,13 @@ export const webpackEagerPathsLoader: IconPathsLoader = async (name, size) => {
/* webpackChunkName: "blueprint-icons-16px" */
/* webpackInclude: /\.js$/ */
/* webpackMode: "eager" */
`./generated/16px/paths/${name}`
`../generated/16px/paths/${name}`
)
: await import(
/* webpackChunkName: "blueprint-icons-20px" */
/* webpackInclude: /\.js$/ */
/* webpackMode: "eager" */
`./generated/20px/paths/${name}`
`../generated/20px/paths/${name}`
)
).default;
};
4 changes: 2 additions & 2 deletions packages/icons/src/webpack-loaders/webpackLazyOncePathsLoader.ts
View file
Original file line number Diff line number Diff line change
@@ -29,13 +29,13 @@ export const webpackLazyOncePathsLoader: IconPathsLoader = async (name, size) =>
/* webpackChunkName: "blueprint-icons-16px" */
/* webpackInclude: /\.js$/ */
/* webpackMode: "lazy-once" */
`./generated/16px/paths/${name}`
`../generated/16px/paths/${name}`
)
: await import(
/* webpackChunkName: "blueprint-icons-20px" */
/* webpackInclude: /\.js$/ */
/* webpackMode: "lazy-once" */
`./generated/20px/paths/${name}`
`../generated/20px/paths/${name}`
)
).default;
};
4 changes: 2 additions & 2 deletions packages/icons/src/webpack-loaders/webpackLazyPathsLoader.ts
View file
Original file line number Diff line number Diff line change
@@ -29,13 +29,13 @@ export const webpackLazyPathsLoader: IconPathsLoader = async (name, size) => {
/* webpackChunkName: "blueprint-icons-16px" */
/* webpackInclude: /\.js$/ */
/* webpackMode: "lazy" */
`./generated/16px/paths/${name}`
`../generated/16px/paths/${name}`
)
: await import(
/* webpackChunkName: "blueprint-icons-20px" */
/* webpackInclude: /\.js$/ */
/* webpackMode: "lazy" */
`./generated/20px/paths/${name}`
`../generated/20px/paths/${name}`
)
).default;
};