[core] feat(Icon): new prop 'svgProps' #5979
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #0000
Checklist
Changes proposed in this pull request:
allow passing of props to SVG element in the Icon.
Reviewers should focus on:
Example usage:
We are using an
Icon
as the target of aTooltip2
. So, we cannot use thetitle
prop of theIcon
, as this creates 2 visible tooltips when hovered (thetitle
html tooltip, and theTooltip2
content
). However, we still need the SVG to have an accessible label, so we want to be able to pass thearia-label
prop to it (as opposed to atitle
). With this, will also override to setaria-hidden=false
(as was given by #5955)