Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] feat(MultistepDialog): tooltips on navigation buttons #5534

Merged
merged 10 commits into from
Sep 14, 2022
+84 −45
Merged

[core] feat(MultistepDialog): tooltips on navigation buttons #5534

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
0d45d7e
init
ohcnivek Sep 10, 2022
a76212a
using tooltip2
ohcnivek Sep 10, 2022
c62605c
cleaning
ohcnivek Sep 10, 2022
66d913c
resetting yarn.lock
ohcnivek Sep 10, 2022
37398bb
updating tooltip import
ohcnivek Sep 10, 2022
0b9a77d
comments
ohcnivek Sep 13, 2022
e24dfd8
oops
ohcnivek Sep 13, 2022
bbff521
Fix compilation and types, use AnchorButton
adidahiya Sep 13, 2022
538bcf6
create DialogStepButton, DRY code
adidahiya Sep 13, 2022
10b967e
Fix test selectors
adidahiya Sep 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
cleaning
@ohcnivek
ohcnivek committed Sep 10, 2022
commit c62605cd759578536a5afc2511afa8db0776b257
6 changes: 3 additions & 3 deletions packages/core/src/components/dialog/multistepDialog.tsx
View file
Original file line number Diff line number Diff line change
@@ -237,7 +237,7 @@ export class MultistepDialog extends AbstractPureComponent2<MultistepDialogProps

if (backButtonProps?.tooltipContent) {
buttons.push(
<Tooltip2 content={backButtonProps?.tooltipContent}>
<Tooltip2 content={backButtonProps?.tooltipContent} hoverOpenDelay={100}>
<Button
key="back"
onClick={this.getDialogStepChangeHandler(selectedIndex - 1)}
@@ -259,7 +259,7 @@ export class MultistepDialog extends AbstractPureComponent2<MultistepDialogProps
if (selectedIndex === this.getDialogStepChildren().length - 1) {
if (this.props.finalButtonProps?.tooltipContent) {
buttons.push(
<Tooltip2 content={this.props.finalButtonProps?.tooltipContent}>
<Tooltip2 content={this.props.finalButtonProps?.tooltipContent} hoverOpenDelay={100}>
<Button intent="primary" key="final" text="Submit" {...this.props.finalButtonProps} />
</Tooltip2>,
);
@@ -271,7 +271,7 @@ export class MultistepDialog extends AbstractPureComponent2<MultistepDialogProps

if (nextButtonProps?.tooltipContent) {
buttons.push(
<Tooltip2 content={nextButtonProps?.tooltipContent}>
<Tooltip2 content={nextButtonProps?.tooltipContent} hoverOpenDelay={100}>
<Button
intent="primary"
key="next"
2 changes: 1 addition & 1 deletion packages/docs-app/src/examples/core-examples/multistepDialogExample.tsx
View file
Original file line number Diff line number Diff line change
@@ -117,7 +117,7 @@ export class MultistepDialogExample extends React.PureComponent<
onClose={this.handleClose}
nextButtonProps={{
disabled: this.state.value === undefined,
tooltipContent: this.state.value === undefined ? "Needs value." : null,
tooltipContent: this.state.value === undefined ? "Needs an input." : null,
}}
finalButtonProps={finalButtonProps}
title={hasTitle ? "Multistep dialog" : undefined}