[table] fix: scrolling bug when grid size == viewport size #5456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to the visible viewport
adidahiya
approved these changes
Jul 22, 2022
adidahiya
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a scrolling bug that is caused by unnecessarily rendering ghost cells when the grid height/width is equal to the viewports height/width (commonly happens if the container element has
height: "auto"). Similar behavior in this past issue #5027Checklist
Changes proposed in this pull request:
Changes
hasVerticalOverflowtohasVerticalOverflowOrExactFitto account for the case where height/width is equal to the viewport where we don't need to render ghost cells.Reviewers should focus on:
Screenshot
before:
after: