[datetime2] feat: DateRangeInput2 component #5390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
adidahiya
commented
Jun 17, 2022
adidahiya
commented
- New DateRangeInput2 component uses Popover2 instead of Popover. It does not have built-in TimezoneSelect support yet.
- DateRangeInput is now deprecated.
deprecate DateRangeInputPreviews: documentation | landing | table | demo |
actually export & use DRP2Previews: documentation | landing | table | demo |
fix test coveragePreviews: documentation | landing | table | demo |
This comment was marked as outdated.
This comment was marked as outdated.
adidahiya
commented
Jul 8, 2022
fix test suitePreviews: documentation | landing | table | demo |
remove describe.onlyPreviews: documentation | landing | table | demo |
update test with new helper fn semanticsPreviews: documentation | landing | table | demo |
|
There are some styling issues with the time picker inside the DateRangePicker, but those are unrelated and will be addressed in a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.