Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[select] fix(Select): matchTargetWidth regression #5380

Merged
merged 3 commits into from
Jun 15, 2022
Merged

[select] fix(Select): matchTargetWidth regression #5380

merged 3 commits into from
Jun 15, 2022

Conversation

adidahiya
Copy link
Contributor

Fixes #5374

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

  • Add unit test suite for Select2, Suggest2, and MultiSelect2 to validate popover behavior like popoverProps.matchTargetWidth
  • Add unit test for Select to validate matchTargetWidth behavior
  • Fix Select component's matchTargetWidth behavior, which regressed in style changes in [select] fix: use renderTarget API to fix fill prop #5354

Reviewers should focus on:

Screenshot

@adidahiya adidahiya changed the title [select] test: add selectPopoverTestSuite [select] fix(Select): matchTargetWidth regression Jun 15, 2022
@blueprint-bot
Copy link

fix test

Previews: documentation | landing | table | demo

@adidahiya adidahiya merged commit e152b53 into develop Jun 15, 2022
@adidahiya adidahiya deleted the ad/select-match-target-width-fix branch June 15, 2022 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Select's matchTargetWidth prop breaks in v4.4.0
2 participants
@adidahiya @blueprint-bot