[select] fix(QueryList): pass menuProps to itemListRenderer #5376
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #0000
Checklist
Changes proposed in this pull request:
So basically, on a previous PR I submitted, we did not consider the case where a user passes a custom itemListRenderer, as they do in the
Select2
example-- in this case, a user needs access to themenuProps
to get the generatedlistboxId
so that they can assignid={listboxId}
to their customMenu
item in their itemListRenderer-- currently, theid={listboxId}
only gets applied to the default itemListRenderer.If this solution isn't approved, the alternative workaround to this would be for a user to create their own
id
, setMenu id=${id}
in their custom itemListRenderer, then passpopoverTargetProps={{aria-controls={id}
. If this isn't approved, I would like to add that example to theSelect2
example implementation