Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[select] fix: ARIA listbox popup type and combobox list role #5348

Merged
merged 34 commits into from
Jun 6, 2022
Merged
Changes from 1 commit
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
9072606
fix list role
bvandercar-vt Jun 2, 2022
0b53086
allow for custom menuProps
bvandercar-vt Jun 2, 2022
4284050
add more props for combobox items
bvandercar-vt Jun 3, 2022
fe900ba
move aria props to entire tagInput
bvandercar-vt Jun 3, 2022
3f819f6
Merge branch 'develop' into bv/select-menu-role
bvandercar-vt Jun 3, 2022
079d996
remove
bvandercar-vt Jun 3, 2022
8e9f410
popoverKind
bvandercar-vt Jun 3, 2022
920734c
fix prop
bvandercar-vt Jun 3, 2022
ed6dd1b
use enum
bvandercar-vt Jun 3, 2022
797d807
fix import
bvandercar-vt Jun 3, 2022
53e0c88
fix imports
bvandercar-vt Jun 3, 2022
8585008
fix props
bvandercar-vt Jun 3, 2022
d586c6a
fix export impoty
bvandercar-vt Jun 3, 2022
89a45e2
Update packages/select/src/components/multi-select/multiSelect2.tsx
bvandercar-vt Jun 3, 2022
382770c
Update packages/select/src/components/multi-select/multiSelect2.tsx
bvandercar-vt Jun 3, 2022
05cf8ed
Update packages/select/src/components/select/select2.tsx
bvandercar-vt Jun 3, 2022
561875a
Update packages/select/src/components/multi-select/multiSelect2.tsx
bvandercar-vt Jun 3, 2022
3d087f2
Update packages/select/src/components/select/select2.tsx
bvandercar-vt Jun 3, 2022
e2f9556
Update packages/select/src/components/select/select2.tsx
bvandercar-vt Jun 3, 2022
599290a
Update packages/select/src/components/select/select2.tsx
bvandercar-vt Jun 3, 2022
7a8d66d
alph order props
bvandercar-vt Jun 3, 2022
f2b9585
listboxId
bvandercar-vt Jun 3, 2022
eeeb0b7
fix
bvandercar-vt Jun 3, 2022
0063836
fix
bvandercar-vt Jun 3, 2022
b4af6a2
fix type
bvandercar-vt Jun 3, 2022
7e6e5cc
fix
bvandercar-vt Jun 3, 2022
80ba2b1
style fix
bvandercar-vt Jun 3, 2022
3c9f8b2
style type
bvandercar-vt Jun 3, 2022
1aad667
fix id uinique
bvandercar-vt Jun 6, 2022
ed42f51
fix imort ts rule
bvandercar-vt Jun 6, 2022
2c82c96
fix import failure
bvandercar-vt Jun 6, 2022
0b58dda
fix import
bvandercar-vt Jun 6, 2022
f97ac9a
fix test
bvandercar-vt Jun 6, 2022
6de075e
fix remove unneede
bvandercar-vt Jun 6, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix
bvandercar-vt committed Jun 3, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit 7e6e5cc4e5ba7c831b0198e4cc02d3eb0e357500
9 changes: 7 additions & 2 deletions packages/select/src/components/multi-select/multiSelect2.tsx
Original file line number Diff line number Diff line change
@@ -30,12 +30,17 @@ import {
} from "@blueprintjs/core";
import { Popover2, PopupKind } from "@blueprintjs/popover2";

import { Classes, SelectPopoverProps } from "../../common";
import { Classes, IListItemsProps, SelectPopoverProps } from "../../common";
import { IQueryListRendererProps, QueryList, QueryListProps } from "../query-list/queryList";

// N.B. selectedItems should really be a required prop, but is left optional for backwards compatibility

export interface MultiSelect2Props<T> extends QueryListProps<T>, SelectPopoverProps {
export interface MultiSelect2Props<T>
extends IListItemsProps<T>,
Partial<
Omit<QueryListProps<T>, "items" | "onItemSelect" | "onQueryChange" | "ref" | "itemRenderer" | "renderer">
>,
SelectPopoverProps {
/**
* Whether the component should take up the full width of its container.
* This overrides `popoverProps.fill` and `tagInputProps.fill`.
9 changes: 7 additions & 2 deletions packages/select/src/components/select/select2.tsx
Original file line number Diff line number Diff line change
@@ -33,10 +33,15 @@ import {
} from "@blueprintjs/core";
import { Popover2, PopupKind } from "@blueprintjs/popover2";

import { Classes, SelectPopoverProps } from "../../common";
import { Classes, IListItemsProps, SelectPopoverProps } from "../../common";
import { IQueryListRendererProps, QueryList, QueryListProps } from "../query-list/queryList";

export interface Select2Props<T> extends QueryListProps<T>, SelectPopoverProps {
export interface Select2Props<T>
extends IListItemsProps<T>,
Partial<
Omit<QueryListProps<T>, "items" | "onItemSelect" | "onQueryChange" | "ref" | "itemRenderer" | "renderer">
>,
SelectPopoverProps {
children?: React.ReactNode;

/**
9 changes: 7 additions & 2 deletions packages/select/src/components/suggest/suggest2.tsx
Original file line number Diff line number Diff line change
@@ -32,10 +32,15 @@ import {
} from "@blueprintjs/core";
import { Popover2, PopupKind } from "@blueprintjs/popover2";

import { Classes, SelectPopoverProps } from "../../common";
import { Classes, IListItemsProps, SelectPopoverProps } from "../../common";
import { IQueryListRendererProps, QueryList, QueryListProps } from "../query-list/queryList";

export interface Suggest2Props<T> extends QueryListProps<T>, SelectPopoverProps {
export interface Suggest2Props<T>
extends IListItemsProps<T>,
Partial<
Omit<QueryListProps<T>, "items" | "onItemSelect" | "onQueryChange" | "ref" | "itemRenderer" | "renderer">
>,
SelectPopoverProps {
/**
* Whether the popover should close after selecting an item.
*