-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[datetime2] feat: new package with timezone-aware components #5322
Merged
+2,431
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bump CI cache key, add missing dependency to new packagePreviews: documentation | landing | table | demo |
Done a number of improvements. Main drawback was probably that we rendered all items initially vs just a subset list, which I've added. Also done a lot more preprocessing. |
Merge remote-tracking branch 'origin/develop' into vh/timezone-aware-date-inputPreviews: documentation | landing | table | demo |
Merge remote-tracking branch 'origin/develop' into vh/timezone-aware-date-inputPreviews: documentation | landing | table | demo |
most of my review comments have been addressed, and I will pick up the rest of the fixes to push this through. Thanks @vhellem!
fix lintPreviews: documentation | landing | table | demo |
fix example width, add fill propPreviews: documentation | landing | table | demo |
Fix file names, improve docsPreviews: documentation | landing | table | demo |
fix test and lintPreviews: documentation | landing | table | demo |
TimezonePicker2 -> TimezoneSelectPreviews: documentation | landing | table | demo |
run new package tests in CIPreviews: documentation | landing | table | demo |
fix test suitePreviews: documentation | landing | table | demo |
renames/refactors for code style; apply strict null checksPreviews: documentation | landing | table | demo |
Fix version depPreviews: documentation | landing | table | demo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Changes proposed in this pull request:
@blueprintjs/datetime
, which includes two new components:@blueprintjs/datetime
)@blueprintjs/timezone
)Reviewers should focus on:
Not done in this PR
These new components are going to require a decent amount of iteration in real products before they are considered good from a UX/DX perspective and their APIs stable. As such, there are a number of improvements which we will not squeeze into this initial PR but leave for future PRs. These include:
<DateInput>
, which currently accepts avalue: Date
<DateInput2>
where we accept aDate
or an ISO string, it will just require a bit more codehideTimezoneSelect: true
by defaultno-deprecated-components
rule to encourage migration -- this should be done after the item 4 is addressedScreenshot