[node-build-scripts] fix(css-variables): string quotes for all values #5304
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
#5303 fixed
generate-css-variables
to preserve string quotes for values inside lists, but after merging that I realized it doesn't actually target the broken use case I needed it to, which is a simple Sass variable value of a single string, like this:Turns out we can simplify the change made in #5303 and apply it to all values which are not (List, Map, Color, or Number) in the JSON encoder.
So now we expect the above variable to be preserved exactly as-is in the output:
Reviewers should focus on:
No regressions w/r/t #5303