-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: declare children prop explicitly for class components #5266
Conversation
fix: declare children prop explicitly for class componentsPreviews: documentation | landing | table | demo |
@@ -26,6 +26,9 @@ import { RadioProps, Radio } from "./controls"; | |||
export type RadioGroupProps = IRadioGroupProps; | |||
/** @deprecated use RadioGroupProps */ | |||
export interface IRadioGroupProps extends Props { | |||
/** Drawer contents. */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/** Drawer contents. */ |
@@ -45,6 +45,8 @@ export interface IPopoverProps extends IPopoverSharedProps { | |||
/** HTML props for the backdrop element. Can be combined with `backdropClassName`. */ | |||
backdropProps?: React.HTMLProps<HTMLDivElement>; | |||
|
|||
children?: React.ReactNode; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should probably go into IPopoverSharedProps
address self-reviewPreviews: documentation | landing | table | demo |
fix test type errorsPreviews: documentation | landing | table | demo |
I am using @types/react 18.0.21 and @blueprintjs/table 4.7.4. I am still getting a type-script error in vscode for Column components:
Any idea? Code example:
|
Fixes #5250
Follow-up to #5258
Changes proposed in this pull request:
Audit all remaining usage of
props.children
. Where components do use children, we now declare that prop type explicitly for compatibility with@types/react@18
.