chore: small improvements to shared ref handler logic #4475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adidahiya
commented
Jan 11, 2021
| public static displayName = `${DISPLAYNAME_PREFIX}.Button`; | ||
|
|
||
| // need to keep this ref so that we can access it in AbstractButton#handleKeyUp | ||
| public buttonRef: HTMLButtonElement | IRefObject<HTMLButtonElement> | null = null; | ||
|
|
||
| protected handleRef: IRef<HTMLButtonElement> = refHandler(this.props.elementRef, this, "buttonRef"); | ||
| protected handleRef: IRef<HTMLButtonElement> = refHandler(this, "buttonRef", this.props.elementRef); |
There was a problem hiding this comment.
before this PR, the first generic type param of refHandler was being inferred as any. now it's HTMLButtonElement.
2 tasks
2 tasks
Fix regression which made IButtonProps type param requiredPreviews: documentation | landing | table |
Fix test compilationPreviews: documentation | landing | table |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #4438
Checklist
Changes proposed in this pull request:
setRefandrefHandlerutilitiesrefHandlerutility, since the ref prop can be optionalIRefHandlerContainerinterface, just list the handlers as separate members in a few placesReviewers should focus on:
Screenshot