Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cb/multi slider.handle class name #4442

Merged
merged 3 commits into from
Jan 19, 2021
Merged

Cb/multi slider.handle class name #4442

merged 3 commits into from
Jan 19, 2021

Conversation

cybae0804
Copy link
Contributor

@cybae0804 cybae0804 commented Dec 1, 2020 •
edited
Loading

Fixes #4440

Checklist

  • Includes tests

Changes proposed in this pull request:

Passes user provided className on MultiSlider.Handle to the rendered span element.

Reviewers should focus on:

I confirmed that the className was being passed locally, and included a simple test.

Screenshot

@SaravananM21
Copy link

+1, would very much like to see this merged!

@adidahiya adidahiya merged commit 5b01159 into palantir:develop Jan 19, 2021
@cybae0804 cybae0804 deleted the CB/MultiSlider.Handle-className branch January 19, 2021 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timothykilgore96 timothykilgore96 timothykilgore96 approved these changes

@adidahiya adidahiya adidahiya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MultiSlider.Handle className prop doesn't seem to be getting propagated to the rendered element.
4 participants
@cybae0804 @SaravananM21 @adidahiya @timothykilgore96