build into the dist/ directory #4
Conversation
a new configurable way to write source files where they should go. public repo will write them to `dist/`, internal one can do whatever. also `gulp/index.js` expects config object instead of `projects` array.
inline linter config simpler autoprefixer browsers remove dests.
cuz individual .d.ts files are sufficient
| @@ -26,7 +26,7 @@ __Prerequisite__: Node.js v5.x | |||
| 1. `git clone` this repository (or fork if you lack permissions) | |||
| 1. `npm install` in the project root | |||
| 1. `gulp` | |||
There was a problem hiding this comment.
let's add the lerna bootstrap step too?
|
fix pure-render-decorator version | Preview |
|
stop copying all those files | Preview |
| @@ -51,9 +42,9 @@ const projects = [ | |||
| ], | |||
| }, | |||
| copy: { | |||
| "src/index.html": {to: [""], base: "src/"}, | |||
| "src/index.html": { to: [""], base: "src/"}, | |||
|
missing end space | Preview |
|
Merge branch 'master' of github.com:palantir/blueprint into gg/build-dist | Preview |
how did these break? i did this already...
|
the last few preview links have been broken... css files weren't loading cuz we weren't copying the build files correctly. fixed now |
|
uh fix docsDist paths | Preview |
|
actually fix docsDist | Preview |
|
holy hell well this is the real fix | Preview |
| @@ -7,7 +7,7 @@ module.exports = (gulp, plugins, blueprint) => { | |||
| const del = require("del"); | |||
| const path = require("path"); | |||
|
|
|||
| const CLEAN_DIRS = ["build", "coverage", "src/generated"]; | |||
| const CLEAN_DIRS = ["build", "coverage", "dist", "src/generated"]; | |||
There was a problem hiding this comment.
Can we remove build and coverage too?
There was a problem hiding this comment.
coverage is still used for code coverage reports.
build i'm leaving for now to ease the transition
|
simpler autoprefixer browsers change | Preview |
|
bring back docs sass | Preview |
| @@ -5,6 +5,7 @@ | |||
|
|
|||
| const path = require("path"); | |||
| const plugins = require("gulp-load-plugins")(); | |||
| const assign = require("lodash/assign"); | |||
| autoprefixer: { | ||
| browsers: ["Chrome >= 37", "Explorer >= 9", "Firefox >= 24", "iOS >= 7", "Safari >= 7"], | ||
| browsers: ["Chrome >= 37", "Explorer >= 11", "Edge > 11", "Firefox >= 24", "Safari >= 7"], |
# This is the 1st commit message: Fix yarn.lock # This is the commit message palantir#2: Fix yarn.lock # This is the commit message palantir#3: Compile blueprint rules # This is the commit message palantir#4: Rerun yarn # This is the commit message palantir#5: Yarn please # This is the commit message palantir#6: I think this is broken
all compiled assets are now written to the
dist/directory. no more two-prongedsrc|global, just one standard location for compiled assets.cc @adidahiya