This repository has been archived by the owner on Nov 14, 2024. It is now read-only.
move to proto3 #2887
Merged
move to proto3 #2887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* deletes defunct proto project/dir * use the newest protobuf gradle plugin * use protobuf 3.5.1 * correctly lock in protobuf-java version * .proto files are now located in a place that makes more sense * generated proto java sources are no longer checked into git Note that all .proto files still use the proto2 spec.
The proto3 compiler generates slightly different classes, so we must use GeneratedMessageV3 instead.
berler
force-pushed
the
feature/proto3
branch
from
d772af3 to
afb5b13
Compare
typo in the release notes table
gsheasby
approved these changes
Jan 19, 2018
|
After looking at this more, I think actually changing GeneratedMessage -> AbstractMessage instead will be better, since both GeneratedMessage and GeneratedMessageV3 extend AbstractMessage. Hopefully this will mean that schemas compiled with the proto2 compiler would still work (so people shouldn't even need to recompile). |
This should hopefully make schemas compiled with the old protobuf compiler still work.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals (and why): Upgrade to the latest protobuf library, so that we can similarly upgrade internal projects that depend on atlas. The old version we use now is vulnerable to protocolbuffers/protobuf#760
Implementation Description (bullets):
Note that all .proto files still use the proto2 spec. It is not trivial to change existing protobufs to use the proto3 spec in a way that is backwards compatible due to using features not present in proto3 (custom default values, enums don't have a zero value)
Concerns (what feedback would you like?):
Where should we start reviewing?:
Priority (whenever / two weeks / yesterday): Normal
This change is