Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing uid gid #22

Merged
merged 2 commits into from
Oct 23, 2023
Merged

Conversation

pacostas
Copy link
Contributor

Summary

The purpose of this PR is to set proper uids and gids on stack images.

Use Cases

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sophiewigmore
Copy link
Member

I'll take a look tomorrow!

@mhdawson
Copy link
Member

In case people wonder about the reason for this.

  1. our images are based on an existing image that used 1001 as the run image
  2. when we originally tested out the nodejs-extension we used 1001 for both the build and run uids. During review it was suggested we be consistent with the rest of the buildpacks and use different uids. We did not know of any issue in doing that so modified to do that.
  3. While @pacostas was running the existing integration tests againt the npm-install buildpack he discoverd a problem with permissions.
  4. Swapping these uids in the way this PR does maintains the separation of using a different uid in the build and run phases while keeping the run uid consistent with what is used in the base images we are extending and resolves the permissions issues we ran into.

sophiewigmore
sophiewigmore previously approved these changes Oct 20, 2023
Copy link
Member

@sophiewigmore sophiewigmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the explanation, this change makes sense to me

@sophiewigmore sophiewigmore dismissed their stale review October 20, 2023 14:59

tests are failing

@sophiewigmore
Copy link
Member

@pacostas changes look good, just need an update to the integration tests here because they are now failing

@sophiewigmore sophiewigmore merged commit c0ad093 into paketo-community:main Oct 23, 2023
@pacostas pacostas deleted the changing-uid-gid branch October 24, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants