Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Copying images.json file on the base stack, only if the file exists #100

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

pacostas
Copy link
Contributor

@pacostas pacostas commented Sep 2, 2024

Summary

This PR places the code that copies the images.json file to the base stack, inside the if statement. That way we ensure that images.json is always available, avoiding any unexpected errors.

Practically this PR is a minor refactor of this PR: #94

Use Cases

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@pacostas pacostas requested a review from a team as a code owner September 2, 2024 09:35
@pacostas
Copy link
Contributor Author

pacostas commented Sep 2, 2024

@mhdawson

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson mhdawson merged commit f4f8bcf into paketo-community:main Sep 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants