Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #289

Merged
merged 1 commit into from
Apr 3, 2023
Merged

Update README.md #289

merged 1 commit into from
Apr 3, 2023

Conversation

dmikusa
Copy link
Contributor

@dmikusa dmikusa commented Apr 3, 2023

Change references from gcr.io to docker.io for stack/builders.

Change references from gcr.io to docker.io for stack/builders.
@dmikusa dmikusa added the type:documentation A documentation update label Apr 3, 2023
@dmikusa dmikusa requested a review from a team as a code owner April 3, 2023 15:18
@dmikusa dmikusa added the semver:patch A change requiring a patch version bump label Apr 3, 2023
@ForestEckhardt ForestEckhardt merged commit 850473b into main Apr 3, 2023
@ForestEckhardt ForestEckhardt deleted the dmikusa-patch-1 branch April 3, 2023 15:23
@andrejusc
Copy link

@dmikusa - I think instead of this in your change:
run-image = "docker.io/paketo-buildpacks/run:tiny-cnb"
it should be this (and could be for other involved images as well):
run-image = "docker.io/paketobuildpacks/run:tiny-cnb"

i.e. from DockerHub without extra dash in the image name.

At least I have such:

podman image ls
REPOSITORY                          TAG         IMAGE ID      CREATED       SIZE
docker.io/paketobuildpacks/run      tiny-cnb    63216a76b12e  4 days ago    19.2 MB
docker.io/paketobuildpacks/builder  tiny        5320ff45280d  43 years ago  633 MB
docker.io/paketocommunity/rust      latest      dfa09c5bb7cd  43 years ago  30.9 MB

Could you double-check?

@dmikusa
Copy link
Contributor Author

dmikusa commented Apr 3, 2023

Shoot. You're right @andrejusc Docker Hub annoyingly doesn't allow a - in the org/user name. I'll fix that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:patch A change requiring a patch version bump type:documentation A documentation update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants