Change target selection to support ARM64 #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the target selection on the tiny/static stacks would assume AMD64/x86_64. This PR changes the behavior to look at the current system architecture and select the correct target for the architecture running. It also enables the `BP_ARCH` environment variable which can be used to override the decision, although this is primarily for testing. Signed-off-by: Daniel Mikusa <[email protected]>
dmikusa
added
semver:patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously, the target selection on the tiny/static stacks would assume AMD64/x86_64. This PR changes the behavior to look at the current system architecture and select the correct target for the architecture running. It also enables the
BP_ARCHenvironment variable which can be used to override the decision, although this is primarily for testing.Use Cases
Enables ARM64.