Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Watchexec & add ARM64 binaries #168

Closed
wants to merge 9 commits into from
Closed

Update Watchexec & add ARM64 binaries #168

wants to merge 9 commits into from

Conversation

dmikusa
Copy link
Contributor

@dmikusa dmikusa commented Oct 19, 2023

Summary

Attempt at adding in ARM64 support.

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@dmikusa dmikusa requested a review from a team as a code owner October 19, 2023 20:57
anthonydahanne
anthonydahanne reviewed Oct 19, 2023
View reviewed changes
buildpack.toml Outdated Show resolved Hide resolved
@dmikusa
Fixing all my typos
8b6594c 
Signed-off-by: Daniel Mikusa <[email protected]>
@dmikusa dmikusa added semver:minor A change requiring a minor version bump type:dependency-upgrade A dependency upgrade labels Oct 20, 2023
@dmikusa
Update URL & hash
d0e867d 
Signed-off-by: Daniel Mikusa <[email protected]>
anthonydahanne
anthonydahanne reviewed Oct 20, 2023
View reviewed changes
buildpack.toml Outdated Show resolved Hide resolved
@anthonydahanne
Copy link
Member

almost there! after I update libpak we can come back and merge!

dmikusa
dmikusa commented Oct 20, 2023
View reviewed changes
buildpack.toml Outdated Show resolved Hide resolved
dmikusa
dmikusa commented Oct 20, 2023
View reviewed changes
buildpack.toml Outdated Show resolved Hide resolved
dmikusa
dmikusa commented Oct 20, 2023
View reviewed changes
buildpack.toml Outdated Show resolved Hide resolved
@dmikusa
Copy link
Contributor Author

dmikusa commented Oct 20, 2023

Does my sha256 for the source look right to you? I grabbed these yesterday and must of messed something up cause they were all wrong today. I think I have them all corrected.

@anthonydahanne anthonydahanne mentioned this pull request Nov 15, 2023
Merged
5 tasks
@anthonydahanne
Copy link
Member

yep, all good to go @dmikusa
Unfortunately, I can't merge in this project.
@pivotal-david-osullivan or @ForestEckhardt could you review and merge please?

@dmikusa dmikusa closed this Jan 21, 2024
@dmikusa dmikusa deleted the dep-updates branch January 21, 2024 02:41
@dmikusa dmikusa mentioned this pull request Jan 21, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robdimsdale robdimsdale robdimsdale left review comments

@anthonydahanne anthonydahanne anthonydahanne approved these changes

Assignees
No one assigned
Labels
semver:minor A change requiring a minor version bump type:dependency-upgrade A dependency upgrade
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dmikusa @anthonydahanne @robdimsdale