use libnodejs function to resolve nodejs version #15

mhdawson · 2023-08-01T17:40:14Z

Summary

Use function added to libnodejs in paketo-buildpacks/libnodejs#14

Use shared functionality from libnodejs where possible

I have viewed, signed, and submitted the Contributor License Agreement.
I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
I have added an integration test, if necessary.
I have reviewed the styleguide for guidance on my code quality.
I'm happy with the commit history on this PR (I have rebased/squashed as needed).

thitch97 · 2023-08-17T19:25:54Z

generate.go

 		entryResolver := draft.NewPlanner()
+		entry, _ := libnodejs.ResolveNodeVersion(entryResolver.Resolve, context.Plan);


@mhdawson Did you still want to keep allEntries around for logging purposes or was this intentional?

Good, catch I rebased on Costas PR which landed recently and fixed that.

Signed-off-by: Michael Dawson <[email protected]>

mhdawson · 2023-08-17T20:03:01Z

@thitch97 addresed your comment above.

thitch97 added the semver:patch A change requiring a patch version bump label Aug 17, 2023

thitch97 reviewed Aug 17, 2023

View reviewed changes

use libnodejs function to resolve nodejs version

ad56f1b

Signed-off-by: Michael Dawson <[email protected]>

mhdawson force-pushed the use-libnodejs-resolve branch from 15c0bd0 to ad56f1b Compare August 17, 2023 20:00

thitch97 approved these changes Aug 18, 2023

View reviewed changes

thitch97 merged commit 367b545 into paketo-buildpacks:main Aug 18, 2023

		entryResolver := draft.NewPlanner()
		entry, _ := libnodejs.ResolveNodeVersion(entryResolver.Resolve, context.Plan);