Skip to content

Commit

Permalink
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: removing println
Browse files Browse the repository at this point in the history
pacostas committed Jan 17, 2024
1 parent 8098e10 commit ba9adb2
Showing 3 changed files with 2 additions and 6 deletions.
4 changes: 2 additions & 2 deletions generate.go
Original file line number Diff line number Diff line change
@@ -56,7 +56,7 @@ func Generate(dependencyManager DependencyManager, logger scribe.Emitter, during
logger.Title("%s %s", context.Info.Name, context.Info.Version)
logger.Process("Resolving Node Engine version")

//find the version with the highest priority
// Find the version with the highest priority
entryResolver := draft.NewPlanner()
highestPriorityNodeVersion, allNodeVersionsInPriorityOrder := libnodejs.ResolveNodeVersion(entryResolver.Resolve, context.Plan)
if highestPriorityNodeVersion.Name == "" {
@@ -65,7 +65,7 @@ func Generate(dependencyManager DependencyManager, logger scribe.Emitter, during

logger.Candidates(allNodeVersionsInPriorityOrder)

//Search and fetch the version from the extension.toml
// Search and fetch the version from the extension.toml
nodeVersion, _ := highestPriorityNodeVersion.Metadata["version"].(string)
extensionFilePath := filepath.Join(context.CNBPath, "extension.toml")
dependency, err := dependencyManager.Resolve(extensionFilePath, highestPriorityNodeVersion.Name, nodeVersion, context.Stack)
2 changes: 0 additions & 2 deletions generate_test.go
Original file line number Diff line number Diff line change
@@ -917,7 +917,6 @@ func testGenerate(t *testing.T, context spec.G, it spec.S) {

buf := new(strings.Builder)
_, _ = io.Copy(buf, generateResult.RunDockerfile)
fmt.Println(buf.String())
Expect(buf.String()).To(Equal(runDockerfileContent))
}
})
@@ -970,7 +969,6 @@ func testGenerate(t *testing.T, context spec.G, it spec.S) {

buf := new(strings.Builder)
_, _ = io.Copy(buf, generateResult.RunDockerfile)
fmt.Println(buf.String())
Expect(buf.String()).To(Equal(runDockerfileContent))
}
})
2 changes: 0 additions & 2 deletions integration/optimize_memory_test.go
Original file line number Diff line number Diff line change
@@ -62,8 +62,6 @@ func testOptimizeMemory(t *testing.T, context spec.G, it spec.S) {
WithPullPolicy("always").
Execute(name, source)

fmt.Println(logs.String())

Expect(err).NotTo(HaveOccurred(), logs.String())

container, err = docker.Container.Run.

0 comments on commit ba9adb2

Please sign in to comment.