Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moves core logic into its own package #33

Merged
merged 1 commit into from
Jul 7, 2022
Merged

Conversation

dmikusa
Copy link

@dmikusa dmikusa commented Jul 7, 2022

This PR moves the core Include/Exclude logic into its own package. This allows the core logic to be imported and reused by other buildpacks or libraries. This core logic package does not depend on packit or libcnb/libpak so it can be used in either style buildpack.

Summary:

  • Creates 'logic' package (not tied to that name)
  • Moves exclude, include and tests into that package
  • Updates buildpack & tests to use logic package

Signed-off-by: Daniel Mikusa [email protected]

Summary

Use Cases

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

Sorry, something went wrong.

This PR moves the core Include/Exclude logic into its own package. This allows the core logic to be imported and reused by other buildpacks or libraries. This core logic package does not depend on packit or libcnb/libpak so it can be used in either style buildpack.

Summary:

- Creates 'logic' package (not tied to that name)
- Moves exclude, include and tests into that package
- Updates buildpack & tests to use logic package

Signed-off-by: Daniel Mikusa <[email protected]>
@dmikusa dmikusa added the enhancement A new feature or request label Jul 7, 2022
@dmikusa dmikusa requested a review from a team as a code owner July 7, 2022 02:01
@dmikusa dmikusa requested a review from ForestEckhardt July 7, 2022 02:02
@dmikusa dmikusa added the semver:minor A change requiring a minor version bump label Jul 7, 2022
@ForestEckhardt ForestEckhardt merged commit 0f66735 into main Jul 7, 2022
@ForestEckhardt ForestEckhardt deleted the separate-package branch July 7, 2022 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A new feature or request semver:minor A change requiring a minor version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants