-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds a Github buildpack loader #644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The draft-release job loads buildpack info from remote sources. Previously, this was loaded from images, but the images can be quite large at times so that is slow. This PR adds a buildpack loader that fetches buildpack metadata from Github. In some cases, image names do not map directly to Github repositories so this PR also adds 'mapper' input parameters which are regular expressions that can be used to rewrite the image URI to a Github project. For example, `mapper_input_1=|foo|bar|` will map foo in the image URI to bar. The code will try both the original unmapped value, as well as the mapped value. If you set multiple mappers, they are all tried in order with the first match that results in a successful load of buildpack metadata being the one that gets used. Signed-off-by: Daniel Mikusa <[email protected]>
dmikusa
added
type:task
A general task
semver:patch
A change requiring a patch version bump
labels
Apr 15, 2022
This was referenced Apr 19, 2022
This was referenced Apr 19, 2022
This was referenced Apr 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The draft-release job loads buildpack info from remote sources. Previously, this was loaded from images, but the images can be quite large at times so that is slow. This PR adds a buildpack loader that fetches buildpack metadata from Github.
In some cases, image names do not map directly to Github repositories so this PR also adds 'mapper' input parameters which are regular expressions that can be used to rewrite the image URI to a Github project. For example,
mapper_input_1=|foo|bar|
will map foo in the image URI to bar. The code will try both the original unmapped value, as well as the mapped value. If you set multiple mappers, they are all tried in order with the first match that results in a successful load of buildpack metadata being the one that gets used.Use Cases
Checklist