Fixes two panics #624
Merged
Fixes two panics #624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmikusa
added
type:bug
dmikusa
force-pushed
the
panic-fix
branch
2 times, most recently
from
beef4a1 to
ad99eba
Compare
Fixes two edge cases where panics can occur. - If there is no package information in the descriptor at all, panics trying to generate repos list - If there is only a single package set, panics when trying to pick the first repo Signed-off-by: Daniel Mikusa <[email protected]>
pivotal-david-osullivan
approved these changes
Apr 11, 2022
dmikusa
commented
Apr 11, 2022
This was referenced Apr 11, 2022
This was referenced Apr 12, 2022
This was referenced Apr 12, 2022
This was referenced Apr 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two edge cases where panics can occur.
Use Cases
Checklist