-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turns off dependabot upgrades of github actions #173
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because certain action versions are hardcoded in our pipeline definition, allowing dependabot to upgrade actions would cause the update-pipeline job and dependebot to fight with each other over the action version. Signed-off-by: Emily Casey <[email protected]>
ekcasey
added
type:bug
A general bug
semver:patch
A change requiring a patch version bump
labels
Feb 8, 2021
ekcasey
changed the title
Turns of dependabot upgrades of github actions
Turns off dependabot upgrades of github actions
Feb 8, 2021
ghost
mentioned this pull request
Feb 8, 2021
This was referenced Feb 8, 2021
ghost
mentioned this pull request
Feb 9, 2021
This was referenced Feb 9, 2021
ghost
mentioned this pull request
Feb 9, 2021
This was referenced Feb 9, 2021
This was referenced Feb 9, 2021
ghost
mentioned this pull request
Feb 9, 2021
This was referenced Feb 9, 2021
ghost
mentioned this pull request
Feb 9, 2021
This was referenced Feb 9, 2021
ghost
mentioned this pull request
Feb 9, 2021
This was referenced Feb 9, 2021
This was referenced Feb 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Because certain action versions are hardcoded in our pipeline definition, allowing dependabot to upgrade actions would cause the update-pipeline job and dependabot to fight with each other over the action version.
Use Cases
For example, this dependabot PR is attempting to change
actions/cache@v2
toactions/[email protected]
. However, if we merge this PR, the pipeline updater will attempt to change it back.Checklist