-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump go.mod version to v2 #545
Bump go.mod version to v2 #545
Conversation
Hello @pbusko 👋 ! Thank you for your contribution :) Can you describe how consuming the versioned node-start from the node-start module will benefit the node-start module? I'm asking for a little bit of context as this change makes sense for consuming external modules, but I can not find a scenario where the same module would benefit from not consuming the latest version of itself. Also, it seems that this change is adding an extra step during development, as for consuming the latest version of the node-start you will have to make a publish first. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
4759564
to
b3c63ba
Compare
I need to clarify the actual benefits of this PR and in case we need to follow a versioning we need to consider strategy for that.
see discussions on paketo-buildpacks/node-engine#966 |
Related issue paketo-buildpacks/nodejs#913 |
Based on discussion in paketo-buildpacks/nodejs#913 we'll land these add hock for now. @pbusko can you rebase and then I'll land. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but a rebase will be needed.
Thank you @mhdawson, the PR has been rebased |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on this paketo-buildpacks/nodejs#913 (comment) , LGTM
@pbusko unfortunately seems to need another rebase. Will enable auto-merge so it should land as soon as the tests pass. I had started them yesterday but seems there was some change between then and now. |
Head branch was pushed to by a user without write access
@pbusko can you rebase again? |
@pbusko can you rebase once more? I thought the auto merge was enabled and in the mid-time another PR automatically landed. sorry :) |
Co-authored-by: Ralf Pannemans <[email protected]>
Head branch was pushed to by a user without write access
@pacostas could you please re-trigger the integration tests? Yet another failure due to the network issues while downloading nodejs package. |
Summary
To reflect the actual major version and follow the official recommendation regarding
go.mod
versioningUse Cases
https://go.dev/doc/modules/version-numbers
Checklist