Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use libreload-packit to handle live reload #270

Merged

Conversation

joshuatcasey
Copy link
Contributor

@joshuatcasey joshuatcasey commented Sep 19, 2022

Use libreload-packit to handle live reload.

Blocked on #269 which is why this diff is so large.

@joshuatcasey joshuatcasey requested a review from a team as a code owner September 19, 2022 05:15
@joshuatcasey joshuatcasey self-assigned this Sep 19, 2022
@joshuatcasey joshuatcasey added semver:patch A change requiring a patch version bump status/blocked This issue has been triaged and resolving it is blocked on some other issue labels Sep 19, 2022
@joshuatcasey joshuatcasey force-pushed the jtc/use-libreload-packit branch from 1854478 to 5aa56b8 Compare September 21, 2022 19:04
@joshuatcasey
Copy link
Contributor Author

@paketo-buildpacks/nodejs-maintainers Can you review please?

Since this PR modifies go.mod / go.sum it's hard to keep it cleanly ahead of main.

Copy link
Contributor

@TisVictress TisVictress left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'll approve once updated

@joshuatcasey joshuatcasey force-pushed the jtc/use-libreload-packit branch 2 times, most recently from 62c7fd7 to bc8d465 Compare September 21, 2022 20:09
@TisVictress TisVictress force-pushed the jtc/use-libreload-packit branch from bc8d465 to a154d6c Compare September 21, 2022 20:18
@TisVictress TisVictress merged commit b83a337 into paketo-buildpacks:main Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:patch A change requiring a patch version bump status/blocked This issue has been triaged and resolving it is blocked on some other issue
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants