Skip to content

Commit

Permalink
checking in case of any error
Browse files Browse the repository at this point in the history
  • Loading branch information
pacostas committed Apr 10, 2024
1 parent 2acafd3 commit a28da06
Showing 1 changed file with 15 additions and 3 deletions.
18 changes: 15 additions & 3 deletions integration/init_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -88,13 +88,25 @@ func TestIntegration(t *testing.T) {
if builder.BuilderName == "index.docker.io/paketocommunity/builder-ubi-buildpackless-base:latest" {
settings.Extensions.UbiNodejsExtension.Online = settings.Config.UbiNodejsExtension
docker.Pull.Execute(settings.Extensions.UbiNodejsExtension.Online)

Check failure on line 90 in integration/init_test.go

View workflow job for this annotation

GitHub Actions / lint

Error return value of `docker.Pull.Execute` is not checked (errcheck)
if err != nil {
t.Fatalf("Failed to pull %s: %s", settings.Extensions.UbiNodejsExtension.Online, err)
}
}
settings.Buildpacks.NodeEngine.Online = settings.Config.NodeEngine
docker.Pull.Execute(settings.Buildpacks.NodeEngine.Online)
err = docker.Pull.Execute(settings.Buildpacks.NodeEngine.Online)
if err != nil {
t.Fatalf("Failed to pull %s: %s", settings.Buildpacks.NodeEngine.Online, err)
}
settings.Buildpacks.NPMInstall.Online = settings.Config.NPMInstall
docker.Pull.Execute(settings.Buildpacks.NPMInstall.Online)
err = docker.Pull.Execute(settings.Buildpacks.NPMInstall.Online)
if err != nil {
t.Fatalf("Failed to pull %s: %s", settings.Buildpacks.NPMInstall.Online, err)
}
settings.Buildpacks.Watchexec.Online = settings.Config.Watchexec
docker.Pull.Execute(settings.Buildpacks.Watchexec.Online)
err = docker.Pull.Execute(settings.Buildpacks.Watchexec.Online)
if err != nil {
t.Fatalf("Failed to pull %s: %s", settings.Buildpacks.Watchexec.Online, err)
}

suite := spec.New("Integration", spec.Report(report.Terminal{}), spec.Parallel())
suite("Default", testDefault)
Expand Down

0 comments on commit a28da06

Please sign in to comment.