Add BPL_DEBUG_ENABLED to set --inspect #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c0d1ngm0nk3y
force-pushed
the
enable-remote-debug
branch
3 times, most recently
from
4b69041 to
24426c3
Compare
c0d1ngm0nk3y
force-pushed
the
enable-remote-debug
branch
from
9748f07 to
9bc4fba
Compare
c0d1ngm0nk3y
force-pushed
the
enable-remote-debug
branch
from
9bc4fba to
a311946
Compare
|
@paketo-buildpacks/nodejs-maintainers Any comments/remarks? It add some convenience when using a debugger. |
|
@paketo-buildpacks/nodejs-maintainers anyone? If I see it correctly, this would add another check on paketo-buildpacks/rfcs#175 which would be nice supposedly. |
Signed-off-by: Ralf Pannemans <[email protected]> Signed-off-by: Pavel Busko <[email protected]> Co-authored-by: Ralf Pannemans <[email protected]>
pbusko
force-pushed
the
enable-remote-debug
branch
from
a311946 to
acc3d96
Compare
|
@paketo-buildpacks/nodejs-maintainers Any chance of getting a review? The actual change is rather smal, but 2 refactorings make it a bit more to review:
|
|
@paketo-buildpacks/nodejs-maintainers ^^ |
|
Apologies for the delay here, folks. I will review this in short order. |
thitch97
approved these changes
Jan 16, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #741
Summary
Add support for
BPL_DEBUG_ENABLEDWe added another helper
inspector. This helper check forBPL_DEBUG_ENABLEDandBPL_DEBUG_PORTand adds the corresponding--inspectto theNODE_OPTIONS.There are 2 main reasons why this pull request seems larger than expected at first sight:
optimize-memory/internalin order to use ittestdata/optimize-memoryand adapted existing and our new test to usetestdata/simple_app.Use Cases
The same could already be achieved by setting
NODE_OPTIONSdirectly, but to implement RFC 0037 it can be configured in the same way as for other buildpacks.Checklist