Quarkus #136
Merged
Quarkus #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 28, 2022 16:26
Prior to this PR, native-image builds would happen with the assumption that the contents of the `/workspace` directory was an exploded JAR file. The buildpack would configure options to build from that location. Recently, buildpacks have gained the capability to build and persist multiple files. This results in the `/workspace` directory not meeting the previous expectation on structure. This PR continues to support building from an exploded JAR file, but also supports building from a JAR file. This requires the user to specify a pattern (Glob match) or file name which points to the JAR file that should the target for the native-image build. When this is set, the buildpack will adjust the build arguments to build from the JAR file. The `$BP_NATIVE_IMAGE_BUILT_ARTIFACT` argument is what controls this behavior. If the `/workspace` directory does not contain an exploded JAR structure, it must have `META-INF/MANIFEST.MF`, then we'll look for files that match the pattern set in `$BP_NATIVE_IMAGE_BUILT_ARTIFACT` and attempt to build from the JAR file at that location. Signed-off-by: Daniel Mikusa <[email protected]>
Previously, you could set arguments through the `$BP_NATIVE_IMAGE_BUILD_ARGUMENTS` env variable, but this is a static set of arguments.. You may now set `$BP_NATIVE_IMAGE_BUILD_ARGUMENTS_FILE` and point to a file that contains arguments, which is handy if your build system generates a file containing arguments to pass to `native-image`. Arguments are now applied in this order: 1. Baseline arguments set by the buildpack 2. If set, arguments from the file `$BP_NATIVE_IMAGE_BUILD_ARGUMENTS_FILE` 3. If any, arguments from `$BP_NATIVE_IMAGE_BUILD_ARGUMENTS` 4. Either arguments required to build from a JAR file or arguments required to build from an exploded JAR directory Arguments from later steps override arguments from lower steps. Signed-off-by: Daniel Mikusa <[email protected]>
dmikusa
added
semver:minor
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR has two components:
It allows you to build from a JAR file. To build from a JAR, there are two requirements. First, your build artifacts must not be an exploded JAR directory. Second, you must set
BP_NATIVE_IMAGE_BUILT_ARTIFACTand instruct the native-image buildpack what JAR file to build. For Quarkus builds with./mvnw -Dquarkus.package.type=native-sources, this would beBP_MAVEN_BUILT_ARTIFACT="target/native-sources".You can build your source code locally and build an image with the
target/native-sourcesdirectory, or you can build using the Maven buildpack and setBP_MAVEN_BUILT_ARTIFACT="target/native-sources".It adds
$BP_NATIVE_IMAGE_BUILD_ARGUMENTS_FILEwhich allows you to specify arguments tonative-imagefrom a file. This is handy with Quarkus which generatesnative-image.args, so you can setBP_NATIVE_IMAGE_BUILD_ARGUMENTS_FILE="native-sources/native-image.args"and the buildpack will automatically load arguments from that file. It will pass through all arguments except the-jar <file>. The buildpack overrides-jarbecause it needs to ensure that the path is correct.Use Cases
Support building from a JAR file, in particular for building Quarkus based apps.
Resolves #109
Checklist