Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not assume buildpack id ends with -buildpacks #88

Merged
merged 1 commit into from
Sep 28, 2021
Merged

Do not assume buildpack id ends with -buildpacks #88

merged 1 commit into from
Sep 28, 2021

Conversation

dmikusa
Copy link
Contributor

@dmikusa dmikusa commented Sep 28, 2021

Summary

The package id regular expression assumes that the package ID will be <something>-buildpacks/<id>. This works for paketo-buildpacks/ and tanzu-buildpacks/. It does not work for the paketocommunity.

This commit modifes the regular expression to permit anything in the form <something>/<id>, which matches previous patterns plus paketocommunity/ as well.

Use Cases

This solves some issues with using libpak and carton tools in Paketo Community projects.

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

Do not assume buildpack id ends with -buildpacks
5340782 
The package id regular expression assumes that the package ID will be `<something>-buildpacks/<id>`. This works for `paketo-buildpacks/` and `tanzu-buildpacks/`. It does not work for the `paketocommunity`.

This commit modifes the regular expression to permit anything in the form `<something>/<id>`, which matches previous patterns plus `paketocommunity/` as well.

Signed-off-by: Daniel Mikusa <[email protected]>
@dmikusa dmikusa added type:enhancement A general enhancement semver:patch A change requiring a patch version bump labels Sep 28, 2021
@dmikusa dmikusa requested a review from a team September 28, 2021 02:09
@dmikusa dmikusa merged commit 67b5706 into main Sep 28, 2021
@dmikusa dmikusa deleted the pkg-update-regex branch September 28, 2021 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
semver:patch A change requiring a patch version bump type:enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dmikusa