Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes a bug where file listing would fail if there is a relative symlink #75

Merged
merged 1 commit into from
Aug 20, 2021
Merged

Fixes a bug where file listing would fail if there is a relative symlink #75

merged 1 commit into from
Aug 20, 2021
+14 −9

Conversation

dmikusa
Copy link
Contributor

@dmikusa dmikusa commented Aug 20, 2021 •
edited
Loading

Summary

This will now resolve relative symlinks based on the parent directory of the symlink.

Ex: /foo/bar/my-link -> my-file
Then: it resolves my-link to /foo/bar/my-file

Use Cases

Bug fix.

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

Fixes a bug where file listing would fail if there is a relative syml…
6dcc6fb 
…ink.

This will now resolve relative symlinks based on the parent directory of the symlink.

Ex: /foo/bar/my-link -> my-file
Then: it resolves my-link to /foo/bar/my-file
Signed-off-by: Daniel Mikusa <[email protected]>
@dmikusa dmikusa added type:bug A general bug semver:patch A change requiring a patch version bump labels Aug 20, 2021
@dmikusa dmikusa requested a review from a team August 20, 2021 17:11
@pivotal-david-osullivan pivotal-david-osullivan merged commit 3f5b5f4 into main Aug 20, 2021
@pivotal-david-osullivan pivotal-david-osullivan deleted the fix_relative_symlink_bug branch August 20, 2021 17:56
@dmikusa dmikusa mentioned this pull request Oct 7, 2021
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pivotal-david-osullivan pivotal-david-osullivan pivotal-david-osullivan approved these changes

Assignees
No one assigned
Labels
semver:patch A change requiring a patch version bump type:bug A general bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmikusa @pivotal-david-osullivan