Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduces a new interface for resolving bindings. #22

Merged
merged 2 commits into from
Nov 2, 2020
Merged

Conversation

ekcasey
Copy link
Member

@ekcasey ekcasey commented Nov 2, 2020

The previous BindingsResolver did not provide an interface for resolving multiple bindings of a given type. Some paketo use-cases such as dependency-mappings and ca-certficates should be able to support an arbitrary number of bindigns. This changes intoduces a new bindings package that exports both Resolve and ResolveOne. In addition it provides functionality that allows the consumer to filter on provider in addition to type.

Signed-off-by: Emily Casey [email protected]

The previous BindingsResolver did not provide an interface for resolving multiple bindings of a given type. Some paketo use-cases such as dependency-mappings and ca-certficates should be able to support an arbitrary number of bindigns. This changes intoduces a new bindings package that exports both Resolve and ResolveOne. In addition it provides functionality that allows the consumer to filter on provider in addition to type.

Signed-off-by: Emily Casey <[email protected]>
@ekcasey ekcasey requested review from nebhale and a team November 2, 2020 21:12
@nebhale nebhale added semver:minor A change requiring a minor version bump type:enhancement A general enhancement labels Nov 2, 2020
bindings/resolve.go Outdated Show resolved Hide resolved
@ekcasey ekcasey merged commit 34ecd2a into main Nov 2, 2020
@ekcasey ekcasey deleted the bindings-resolve branch November 2, 2020 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:minor A change requiring a minor version bump type:enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants