Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't shell parse all config values #38

Closed
3 tasks done
ekcasey opened this issue Jan 19, 2021 · 0 comments · Fixed by #39
Closed
3 tasks done

Don't shell parse all config values #38

ekcasey opened this issue Jan 19, 2021 · 0 comments · Fixed by #39

Comments

@ekcasey
Copy link
Member

ekcasey commented Jan 19, 2021

What happened?

We shouldn't shell parse all configuration values. Some values are not shell words and fail to parse, resulting in failed builds. Instead buildpacks that accept shell word configuration should parse these values.

  • What were you attempting to do?
    Using the paketo sample jar app: https://github.com/paketo-buildpacks/samples/tree/main/java/jar

    pack build samples/jar --env BP_OCI_DESCRIPTION="some(example)string" --builder paketobuildpacks/builder:base
    
  • What did you expect to happen?

    A successful build with label key org.opencontainers.image.description set to value some(example)string

  • What was the actual behavior? Please provide log output, if possible.

    Paketo Image Labels Buildpack 2.0.6
      https://github.com/paketo-buildpacks/image-labels
    
    Paketo Image Labels Buildpack 2.0.6
      unable to create configuration resolver
      unable to parse value
      invalid command line string
    

Build Configuration

  • What platform (pack, kpack, tekton buildpacks plugin, etc.) are you
    using? Please include a version.

    pack version
    0.16.0+git-e0f6c50.build-1898
    
  • What buildpacks are you using? Please include versions.

    Paketo Image Labels Buildpack 2.0.6
      https://github.com/paketo-buildpacks/image-labels
    
  • What builder are you using? If custom, can you provide the output from pack inspect-builder <builder>?

    paketobuildpacks/builder:base
    
  • Can you provide a sample app or relevant configuration (buildpack.yml,
    nginx.conf, etc.)?

    https://github.com/paketo-buildpacks/samples/tree/main/java/jar

Checklist

  • I have included log output.
  • The log output includes an error message.
  • I have included steps for reproduction.
ekcasey added a commit that referenced this issue Jan 19, 2021
* Resolves #38

Signed-off-by: Emily Casey <[email protected]>
ekcasey added a commit that referenced this issue Jan 19, 2021
* Resolves #38

Signed-off-by: Emily Casey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant