Skip to content

Commit

Permalink
Docker URI
Browse files Browse the repository at this point in the history
This change updates the update-package-dependency command to support the uri
tag instead of the image tag.

Signed-off-by: Ben Hale <[email protected]>
  • Loading branch information
nebhale committed Nov 13, 2020
1 parent d888e7e commit 07b6c98
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion carton/package_dependency.go
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ import (

const (
PackageIdDependencyPattern = `(?m)(.*id[\s]+=[\s]+".+-buildpacks/%s",[\s]+version=")[^"]+(".*)`
PackageImageDependencyPattern = `(?m)(.*image[\s]+=[\s]+"%s:)[^"]+(".*)`
PackageImageDependencyPattern = `(?m)(.*uri[\s]+=[\s]+".*%s:)[^"]+(".*)`
PackageDependencySubstitution = "${1}%s${2}"
)

Expand Down
16 changes: 8 additions & 8 deletions carton/package_dependency_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,8 @@ func testPackageDependency(t *testing.T, context spec.G, it spec.S) {

it("updates builder dependency", func() {
Expect(ioutil.WriteFile(path, []byte(`
{ id = "paketo-buildpacks/test-1", image = "gcr.io/paketo-buildpacks/test-1:test-version-1" },
{ id = "paketo-buildpacks/test-2", image = "gcr.io/paketo-buildpacks/test-2:test-version-2" },
{ id = "paketo-buildpacks/test-1", uri = "docker://gcr.io/paketo-buildpacks/test-1:test-version-1" },
{ id = "paketo-buildpacks/test-2", uri = "docker://gcr.io/paketo-buildpacks/test-2:test-version-2" },
`), 0644)).To(Succeed())

p := carton.PackageDependency{
Expand All @@ -88,15 +88,15 @@ func testPackageDependency(t *testing.T, context spec.G, it spec.S) {
p.Update(carton.WithExitHandler(exitHandler))

Expect(ioutil.ReadFile(path)).To(Equal([]byte(`
{ id = "paketo-buildpacks/test-1", image = "gcr.io/paketo-buildpacks/test-1:test-version-3" },
{ id = "paketo-buildpacks/test-2", image = "gcr.io/paketo-buildpacks/test-2:test-version-2" },
{ id = "paketo-buildpacks/test-1", uri = "docker://gcr.io/paketo-buildpacks/test-1:test-version-3" },
{ id = "paketo-buildpacks/test-2", uri = "docker://gcr.io/paketo-buildpacks/test-2:test-version-2" },
`)))
})

it("updates package dependency", func() {
Expect(ioutil.WriteFile(path, []byte(`
{ image = "gcr.io/paketo-buildpacks/test-1:test-version-1" },
{ image = "gcr.io/paketo-buildpacks/test-2:test-version-2" },
{ uri = "docker://gcr.io/paketo-buildpacks/test-1:test-version-1" },
{ uri = "docker://gcr.io/paketo-buildpacks/test-2:test-version-2" },
`), 0644)).To(Succeed())

p := carton.PackageDependency{
Expand All @@ -108,8 +108,8 @@ func testPackageDependency(t *testing.T, context spec.G, it spec.S) {
p.Update(carton.WithExitHandler(exitHandler))

Expect(ioutil.ReadFile(path)).To(Equal([]byte(`
{ image = "gcr.io/paketo-buildpacks/test-1:test-version-3" },
{ image = "gcr.io/paketo-buildpacks/test-2:test-version-2" },
{ uri = "docker://gcr.io/paketo-buildpacks/test-1:test-version-3" },
{ uri = "docker://gcr.io/paketo-buildpacks/test-2:test-version-2" },
`)))
})

Expand Down

0 comments on commit 07b6c98

Please sign in to comment.