Add support for building composite buildpacks #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR resolves #48. In addition, it fixes a bug where a missing `BP_ROOT` was ignored, which was confusing. It also does a little refactoring renaming some variables to better indicate intent. Signed-off-by: Daniel Mikusa <[email protected]>
dmikusa
added
type:enhancement
dmikusa
commented
Nov 18, 2024
anthonydahanne
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves #48. It adds the ability for
libpak-tools package bundleto build composite buildpacks. It does nothing fancy and is just a wrapper around the similar pack command, but it does help to enforce some default settings so it should be as easy aslibpak-tools package bundle --buildpack-id paketo-buildpacks/javato build the composite.You can then manually adjust
package.tomland point to local images, rebuild and get a composite image with custom buildpack changes.In addition, it fixes a bug where a missing
BP_ROOTwas ignored, which was confusing. It also does a little refactoring renaming some variables to better indicate intent.Use Cases
Build composite buildpacks.