Npm start script override #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhdawson
requested review from
ryanmoran and
thitch97
and removed request for
a team
mhdawson
force-pushed
the
npm-start-script-override
branch
from
c22abd0 to
4c5dddf
Compare
|
We could hide AllScripts versus exposing it but I could not come up with a good reason to do that since we are parsing/decoding it already. |
|
@thitch97 any chance you could take a look? |
TisVictress
suggested changes
May 30, 2023
|
@TisVictress will update to remove written files in next few days. |
|
@TisVictress pushed commit to do clean of workingDir after each test. Since all files are written in workingDir that should ensure all files are cleaned up. |
|
@TisVictress ping |
thitch97
approved these changes
Jun 29, 2023
TisVictress
approved these changes
Jun 29, 2023
|
@mhdawson I'm sorry to respond so late. I merged the other two PRs. Could you resolve the above conflicts? |
Refs: paketo-buildpacks/npm-start#292 Signed-off-by: Michael Dawson <[email protected]>
mhdawson
force-pushed
the
npm-start-script-override
branch
from
7ef4b91 to
3d5698b
Compare
|
@TisVictress conflicts resolved and PR updated. Thanks for your help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for BP_NPM_START_SCRIPT as requested in paketo-buildpacks/npm-start#292.
Use Cases
See paketo-buildpacks/npm-start#292
Checklist