-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add initial version of actions #2
Conversation
Signed-off-by: Michael Dawson <[email protected]>
@ryanmoran not sure if these is correct or not but thought I'd take a try at it since I think we need releases before I can open PRs to use the shread functionality from other packages. It's mostly a copy of the actions/files that were there for node-engine with integration tests removed as I think those will be covered instead by the buildpacks that used the shared library. I also did not copy over the action that updated dependencies as I don't think this package has any, at least to start. |
@mhdawson I'm not a Node maintainer, so we should wait for one of them to give you an official approval, but these changes look good to me. You probably also need to copy in the Just a heads up also - the update github config workflow will overwrite any changes to the workflows you have made when it runs (like the removal of integration tests) and just update the workflows and scripts to match what we have here: https://github.com/paketo-buildpacks/github-config/tree/main/implementation. Our integration script should be smart enough to just warn about no integration tests, but not fail out when it runs if there aren't any tests to run so that should be OK. |
@sophiewigmore thanks for reviewing. In terms of the scripts I think we already have those in the repo as part of the initial commit - https://github.com/paketo-buildpacks/libnodejs/tree/main/scripts EDIT: Also thanks for the clarification about scripts being copied over. It's good to know that is part of the process and also that it will likely just warn about integration tests. |
Co-authored-by: Ryan Moran <[email protected]>
@ryanmoran I accepted your suggested change to use |
@mhdawson I don't think so. The key workflow here is that |
Summary
Add the base actions to check PRs, build releases etc.
Use Cases
Need so that we have published versions we can start consuming in other
buildpacks.
Checklist