Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add initial version of actions #2

Merged
merged 2 commits into from
Mar 31, 2023

Conversation

mhdawson
Copy link
Member

@mhdawson mhdawson commented Mar 23, 2023

Summary

Add the base actions to check PRs, build releases etc.

Use Cases

Need so that we have published versions we can start consuming in other
buildpacks.

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@mhdawson
Copy link
Member Author

@ryanmoran not sure if these is correct or not but thought I'd take a try at it since I think we need releases before I can open PRs to use the shread functionality from other packages.

It's mostly a copy of the actions/files that were there for node-engine with integration tests removed as I think those will be covered instead by the buildpacks that used the shared library. I also did not copy over the action that updated dependencies as I don't think this package has any, at least to start.

@sophiewigmore sophiewigmore requested review from a team, thitch97 and paketo-bot-reviewer and removed request for a team March 28, 2023 10:20
@sophiewigmore
Copy link
Member

sophiewigmore commented Mar 28, 2023

@mhdawson I'm not a Node maintainer, so we should wait for one of them to give you an official approval, but these changes look good to me. You probably also need to copy in the scripts directory, since some of the worklows use them (like the unit test step uses ./scripts/unit.sh)

Just a heads up also - the update github config workflow will overwrite any changes to the workflows you have made when it runs (like the removal of integration tests) and just update the workflows and scripts to match what we have here: https://github.com/paketo-buildpacks/github-config/tree/main/implementation. Our integration script should be smart enough to just warn about no integration tests, but not fail out when it runs if there aren't any tests to run so that should be OK.

@mhdawson
Copy link
Member Author

mhdawson commented Mar 28, 2023

@sophiewigmore thanks for reviewing. In terms of the scripts I think we already have those in the repo as part of the initial commit - https://github.com/paketo-buildpacks/libnodejs/tree/main/scripts

EDIT: Also thanks for the clarification about scripts being copied over. It's good to know that is part of the process and also that it will likely just warn about integration tests.

@mhdawson
Copy link
Member Author

@ryanmoran I accepted your suggested change to use library is there something more I should do to the PR in terms of looking at what the default files are for library and updating the other files in the PR?

@ryanmoran
Copy link
Member

@mhdawson I don't think so. The key workflow here is that update-github-config.yml one anyway. Once that lands, the repo will converge itself on the right set of files. I'm happy to go ahead and merge this to let that process take place.

@ryanmoran ryanmoran merged commit c687aed into paketo-buildpacks:main Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants