Add function to get version from package.json #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
package_json_parser needs to parse version to be re-used in npm-install buildpack. Signed-off-by: Michael Dawson <[email protected]>
mhdawson
requested review from
ryanmoran and
thitch97
and removed request for
a team
|
This is the change to make npm-install use the new functioality. Will submit a PR on paketo-buildpacks/npm-install once this PR lands and there is a new version of libnodejs - mhdawson/npm-install@6a25e53 |
|
@thitch97 any chance you could take a look? |
TisVictress
reviewed
May 30, 2023
|
|
||
| context("ParseVersion", func() { | ||
| it.Before(func() { | ||
| Expect(os.WriteFile(filePath, []byte(`{ |
There was a problem hiding this comment.
@mhdawson Each time the file is written, can it be deleted to keep things clean? (it.After)
There was a problem hiding this comment.
Sure will look at doing that in next few days.
There was a problem hiding this comment.
Pushed commit do do cleanup
TisVictress
suggested changes
May 30, 2023
Signed-off-by: Michael Dawson <[email protected]>
|
@TisVictress pushed commit to add cleanup of workingDir after every test. All files are written to that workingDir so that should makes sure that all files writen are deleted after the test completes. |
|
@TisVictress ping |
thitch97
added
semver:minor
thitch97
approved these changes
Jun 29, 2023
TisVictress
approved these changes
Jun 29, 2023
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
package_json_parser needs to parse version to be
re-used in npm-install buildpack.
Summary
Add parsing version in package.json helpers so that shared code
can be reused in npm-install
Use Cases
reduce duplicated code and centralize knowledge of constants
Checklist