Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not add debug options if already available in JAVA_TOOL_OPTIONS #280

Merged

Conversation

c0d1ngm0nk3y
Copy link
Contributor

fixes #274

Summary

If the java agent is already configured via JAVA_TOOL_OPTIONS, it is not added a second time since this would cause an error when starting the java process.

Use Cases

see issue

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@c0d1ngm0nk3y c0d1ngm0nk3y requested a review from a team as a code owner April 19, 2023 09:11
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 19, 2023

CLA Missing ID CLA Not Signed

Co-authored-by: Johannes Dillmann <[email protected]>
Co-authored-by: Ralf Pannemans <[email protected]>
@c0d1ngm0nk3y c0d1ngm0nk3y force-pushed the 274-debug-already-present branch from 1082450 to 7188912 Compare April 19, 2023 09:13
@dmikusa dmikusa added type:bug A general bug semver:patch A change requiring a patch version bump labels Apr 19, 2023
@dmikusa
Copy link
Contributor

dmikusa commented Apr 19, 2023

Ignore EasyCLA for now. It seems to have lost its mind. Hopefully, that will be resolved soon.

@dmikusa
Copy link
Contributor

dmikusa commented Apr 21, 2023

/easycla

@dmikusa dmikusa merged commit 1c0e73b into paketo-buildpacks:main Apr 21, 2023
@dmikusa
Copy link
Contributor

dmikusa commented Apr 21, 2023

Thanks!

@c0d1ngm0nk3y
Copy link
Contributor Author

@dmikusa Any idea when the next release is made? We are waiting for this change...

@dmikusa
Copy link
Contributor

dmikusa commented May 3, 2023

Sorry, I'll cut a release now. In the future, ping me or David and we can get stuff like this going more quickly.

It won't make it into the composites this week, but we can probably get the SAP Machine buildpack updated this week. I suspect that's the one you care about most?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:patch A change requiring a patch version bump type:bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't add debug config if it's already present
2 participants