Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuilds when build system arguments or artifact patterns change #3

Merged
merged 1 commit into from
May 11, 2020

Conversation

ekcasey
Copy link
Member

@ekcasey ekcasey commented May 11, 2020

Even if the source files are identical between builds, a change to the build
configuration can produce different build results. Therefore we must
rebuild the application when certain configuration changes.

This solves for cases common to all build system implementations.

Rebuilds on:

  1. changes to build arguments
  2. changes to artifact patterns resolved from configured artifact path or module

Still missing:

  1. provide mechanism for build system implementation specific cache invalidation (e.g.
    hash of maven settings.xml)

Signed-off-by: Emily Casey [email protected]

Even if the source files are identical between builds, a change to the build
configuration can produce different build results. Therefore we must
rebuild the application when certain configuration changes.

This solves for cases common to all build system implementations.

Rebuilds on:
1. changes to build arguments
2. changes to artifact patterns resolved from configured artifact path or module

Still missing:
1. provide mechanism for build system implementation specific cache invalidation (e.g.
hash of maven settings.xml)

Signed-off-by: Emily Casey <[email protected]>
@linux-foundation-easycla
Copy link

CLA Check

@nebhale nebhale self-requested a review May 11, 2020 22:50
@nebhale nebhale merged commit 1c1e78b into master May 11, 2020
@nebhale nebhale deleted the rebuild-on-arg-and-config-changes branch May 11, 2020 22:54
@nebhale nebhale added semver:minor A change requiring a minor version bump type:task A general task labels Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:minor A change requiring a minor version bump type:task A general task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants