Allow multiple space separated globs for artifacts specification #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The globs shall be space separated. This allows usage as: `--env BP_MAVEN_BUILT_ARTIFACT="target/*runner*.jar target/lib"`. Signed-off-by: Matej Vasek <[email protected]>
|
/cc @dmikusa-pivotal |
|
/cc @jjbustamante |
dmikusa
added
semver:minor
Signed-off-by: Matej Vasek <[email protected]>
Signed-off-by: Matej Vasek <[email protected]>
- Errors will only occur from `filepath.Glob` if there's a bad pattern (it doesn't return i/o errors). Thus we can collect bad patterns and return them all at once. It'll be a slightly nicer user experience when there are errors. - Add more tests around parsing patterns - Fix some Paketo Java buildpacks style issues Signed-off-by: Daniel Mikusa <[email protected]>
Signed-off-by: Daniel Mikusa <[email protected]>
…tiple-globs Adjust error handling and more tests
dmikusa
approved these changes
Feb 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This allows usage as:
--env BP_MAVEN_BUILT_ARTIFACT="target/*runner*.jar target/lib".Use Cases
Useful when including only
*-runner.jarandlibdirectory to resulting app image instead of wholetarget.Checklist